Re: [PATCH v6 27/45] vmw_balloon: dynamically allocate the vmw-balloon shrinker

From: Nadav Amit
Date: Mon Sep 11 2023 - 17:40:14 EST




> On Sep 11, 2023, at 2:44 AM, Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx> wrote:
>
> In preparation for implementing lockless slab shrink, use new APIs to
> dynamically allocate the vmw-balloon shrinker, so that it can be freed
> asynchronously via RCU. Then it doesn't need to wait for RCU read-side
> critical section when releasing the struct vmballoon.
>
> And we can simply exit vmballoon_init() when registering the shrinker
> fails. So the shrinker_registered indication is redundant, just remove it.
>
> Signed-off-by: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>
> Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
> CC: Nadav Amit <namit@xxxxxxxxxx>
> CC: VMware PV-Drivers Reviewers <pv-drivers@xxxxxxxxxx>
> CC: Arnd Bergmann <arnd@xxxxxxxx>
> CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Acked-by: Nadav Amit <namit@xxxxxxxxxx>