Re: [PATCH 1/3] dt-bindings: interconnect: Add Qualcomm SM4450

From: Tengfei Fan
Date: Mon Sep 11 2023 - 17:41:10 EST




在 9/8/2023 4:25 PM, Tengfei Fan 写道:


在 9/8/2023 3:42 PM, Rob Herring 写道:

On Fri, 08 Sep 2023 14:44:25 +0800, Tengfei Fan wrote:
The Qualcomm SM4450 SoC has several bus fabrics that could be controlled
and tuned dynamically according to the bandwidth demand.

Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
---
  .../interconnect/qcom,sm4450-rpmh.yaml        | 133 ++++++++++++++
  .../dt-bindings/interconnect/qcom,sm4450.h    | 163 ++++++++++++++++++
  2 files changed, 296 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sm4450-rpmh.yaml
  create mode 100644 include/dt-bindings/interconnect/qcom,sm4450.h


My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/interconnect/qcom,sm4450-rpmh.example.dts:18:18: fatal error: dt-bindings/clock/qcom,gcc-sm4450.h: No such file or directory
    18 |         #include <dt-bindings/clock/qcom,gcc-sm4450.h>
       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/interconnect/qcom,sm4450-rpmh.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230908064427.26999-2-quic_tengfan@xxxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Thanks review this patch, will setup new env for verify again.

this error is due to have dependence with: https://lore.kernel.org/linux-arm-msm/20230824173410.550126-1-quic_ajipan@xxxxxxxxxxx/, will add this link to coverletter.

--
Thx and BRs,
Tengfei Fan