Re: [PATCH] dt-bindings: arm64: dts: mediatek: add description for mt8365-evk board

From: Krzysztof Kozlowski
Date: Mon Sep 11 2023 - 18:07:11 EST


On 11/09/2023 10:16, Macpaul Lin wrote:
>
>
> On 9/11/23 15:06, Krzysztof Kozlowski wrote:
>>
>>
>> External email : Please do not click links or open attachments until you
>> have verified the sender or the content.
>>
>> On 11/09/2023 08:34, Macpaul Lin wrote:
>>> On 9/11/23 14:09, Krzysztof Kozlowski wrote:
>>>>
>>>>
>>>> External email : Please do not click links or open attachments until you
>>>> have verified the sender or the content.
>>>>
>>>> On 10/09/2023 14:07, Macpaul Lin wrote:
>>>>>
>>>>>
>>>>> On 9/10/23 17:09, Krzysztof Kozlowski wrote:
>>>>>>> + - description: MediaTek Genio 350 Boards (Genio 350 EVK)
>>>>>>
>>>>>> That's a bit confusing. So all of the boards here will be Genio 350 EVK?
>>>>>> I don't get what is the point of this description.
>>>>>>
>>>>>>
>>>>>>> + items:
>>>>>>> - enum:
>>>>>>> - mediatek,mt8365-evk
>>>>>>> - const: mediatek,mt8365
>>>>>
>>>>> Thes boards with compatible 'mediatek,mt8365-evk' is indeed used by
>>>>
>>>> Boards?
>>>
>>> I'm not sure if there will be more hardware version released to market.
>>> Current the p1v3 is the final version of mt8365-evk.
>>
>> Then your code (enum) does not match description. The code is saying:
>> this is for multiple boards based on mt8365.
>>
>> Your description is saying: this is only for 350 boards.
>>
>> Now your email is saying: there is only one 350 board.
>>
>> Three different versions. Sorry, I am confused.
>>
>
> Okay, this description has been modified to support single board.
> Since there is only one type of the hardware is available on the market.

Then why the code uses enum?



Best regards,
Krzysztof