Re: [PATCH] kbuild: fix kernel-devel RPM package and linux-headers Deb package

From: Nicolas Schier
Date: Mon Sep 11 2023 - 18:44:20 EST


On Sun, Sep 10, 2023 at 09:44:13PM +0900, Masahiro Yamada wrote:
> Since commit fe66b5d2ae72 ("kbuild: refactor kernel-devel RPM package
> and linux-headers Deb package"), the kernel-devel RPM package and
> linux-headers Deb package are broken.
>
> I double-quoted the $(find ... -type d), which resulted in newlines
> being included in the argument to the outer find comment.
>
> find: 'arch/arm64/include\narch/arm64/kvm/hyp/include': No such file or directory
>
> The outer find command is unneeded.
>
> Fixes: fe66b5d2ae72 ("kbuild: refactor kernel-devel RPM package and linux-headers Deb package")
> Reported-by: Karolis M <k4rolis@xxxxxxxxxxxxxx>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
>
> scripts/package/install-extmod-build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/package/install-extmod-build b/scripts/package/install-extmod-build
> index af7fe9f5b1e4..8a7051fad087 100755
> --- a/scripts/package/install-extmod-build
> +++ b/scripts/package/install-extmod-build
> @@ -20,7 +20,7 @@ mkdir -p "${destdir}"
> find "arch/${SRCARCH}" -maxdepth 1 -name 'Makefile*'
> find include scripts -type f -o -type l
> find "arch/${SRCARCH}" -name Kbuild.platforms -o -name Platform
> - find "$(find "arch/${SRCARCH}" -name include -o -name scripts -type d)" -type f
> + find "arch/${SRCARCH}" -name include -o -name scripts -type d
> ) | tar -c -f - -C "${srctree}" -T - | tar -xf - -C "${destdir}"
>
> {
> --
> 2.39.2

Reviewed-by: Nicolas Schier <n.schier@xxxxxx>