Re: [PATCH v3 0/7] arm64: ti: k3-j7: Add the ESM & main domain watchdog nodes

[Kumar, Udit]

Hi Keerthy

On 9/11/2023 9:39 AM, Keerthy wrote:
> The series add the ESM & main domain watchdog nodes for j721s2,
> j784s4 SOCs.
>
> Changes in v3:
>
> 	* Added all the RTI events for MAIN_ESM for j784s4 as 8 instances
> 	  are enabled.
> 	* Rebased on top of 6.6-rc1
> 	* Tested for the watchdog reset
>
> RESEND series - corrected krzysztof.kozlowski+dt@xxxxxxxxxx ID
>
> Changes in v2:
>
>          * Added all the instances of watchdog on j784s4/j721s2
>          * Fixed all 0x0 in dts to 0x00
>          * Fixed couple of ESM event numbers for j721s2
>          * Rebased to linux-next branch
>
> Keerthy (7):
>    arm64: dts: ti: k3-j721s2: Add ESM instances
>    arm64: dts: ti: k3-j784s4: Add ESM instances
>    arm64: dts: ti: k3-j7200: Add MCU domain ESM instance
>    arm64: dts: ti: k3-j784s4-main: Add the main domain watchdog instances
>    arm64: dts: ti: k3-j784s4-mcu: Add the main domain watchdog instances
>    arm64: dts: ti: k3-j721s2-main: Add the main domain watchdog instances
>    arm64: dts: ti: k3-j721s2-mcu: Add the main domain watchdog instances

Thanks for series,

Two minor suggestions.

1) Order of patches , since J721S2 esm is added first , it will be 
better to have  watchdog for J721S2 first

2) I understand, to add watchdog entries, for J784S4 and J721S2, you 
followed ascending device id order

due to that there is mix of entries like watchdog16 coming before 
watchdog15.


Let maintainers to take call on these minor one.


For me, with or without above suggestions fix.

Reviewed-by: Udit Kumar <u-kumar1@xxxxxx>


>   .../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi      |   6 +
>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi    |  94 +++++++++
>   .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi     |  32 +++
>   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi    | 189 ++++++++++++++++++
>   .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi     |  32 +++
>   5 files changed, 353 insertions(+)