Re: [PATCH v20 28/30] LoongArch: KVM: Enable kvm config and add the makefile

From: zhaotianrui
Date: Mon Sep 11 2023 - 22:34:08 EST



在 2023/9/11 下午3:30, WANG Xuerui 写道:
On 8/31/23 16:30, Tianrui Zhao wrote:
[snip]
+
+config AS_HAS_LVZ_EXTENSION
+    def_bool $(as-instr,hvcl 0)

Upon closer look it looks like this piece could use some improvement as well: while presence of "hvcl" indeed always implies full support for LVZ instructions, "hvcl" however isn't used anywhere in the series, so it's not trivially making sense. It may be better to test for an instruction actually going to be used like "gcsrrd". What do you think?
Thanks for your advice, and I think both "hvcl" and "gcsrrd" instructions which are supported by binutils mean that the cpu support LVZ extension, so I think they have the same meaning there.

Thanks
Tianrui Zhao