Re: [PATCH v1 11/17] lib: add light-weight queuing mechanism.

From: Andrew Morton
Date: Mon Sep 11 2023 - 22:42:25 EST


On Mon, 11 Sep 2023 20:30:40 +0000 Chuck Lever III <chuck.lever@xxxxxxxxxx> wrote:

>
>
> > On Sep 11, 2023, at 2:13 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Mon, 11 Sep 2023 10:39:43 -0400 Chuck Lever <cel@xxxxxxxxxx> wrote:
> >
> >> lwq is a FIFO single-linked queue that only requires a spinlock
> >> for dequeueing, which happens in process context. Enqueueing is atomic
> >> with no spinlock and can happen in any context.
> >
> > What is the advantage of this over using one of the library
> > facilities which we already have?
>
> I'll let the patch author respond to that question, but let me pose
> one of my own: What pre-existing facilities are you thinking of, so
> that I may have a look?

Well, I assume that plain old list_heads could be recruited for this
requirement. And I hope that a FIFO could be implemented using kfifo ;)