Re: [PATCH v3 1/4] platform/x86: intel_scu_ipc: Check status after timeout in busy_loop()
From: Andy Shevchenko
Date: Mon Sep 11 2023 - 23:10:02 EST
On Tue, Sep 12, 2023 at 12:17:22AM +0300, Andy Shevchenko wrote:
> On Mon, Sep 11, 2023 at 12:39:33PM -0700, Stephen Boyd wrote:
...
> > + err = read_poll_timeout(ipc_read_status, status, !(status & IPC_STATUS_BUSY),
> > + 100, jiffies_to_usecs(IPC_TIMEOUT), false, scu);
>
> Since "false" you probably can utilize readx_poll_timeout().
...and because only a single parameter taken.
> > + if (err)
> > + return err;
With that,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko