Re: [PATCH v1 11/17] lib: add light-weight queuing mechanism.

From: NeilBrown
Date: Tue Sep 12 2023 - 00:08:22 EST


On Tue, 12 Sep 2023, Kees Cook wrote:
> On September 11, 2023 7:39:43 AM PDT, Chuck Lever <cel@xxxxxxxxxx> wrote:
> >From: NeilBrown <neilb@xxxxxxx>
> > [...]
> > Does not use kunit framework.
>
> Any reason why not? It seems like it'd be well suited to it...

A quick look didn't suggest that using Kunit would make my task any
easier. It seemed to require a lot of boiler plate for little gain.
Maybe that was unfair - I didn't spend long looking.
Partly, I put that comment in the commit message so that if one wanted
to try to change my mind - there was a prompt for them to do it.

Also I had a quick look at other test code in lib/ and it all seemed to
use the "run some code at boot time" approach.

So if anyone can make a clear argument why using Kunit will help me, or
will help someone else, I'll consider it. But I cannot see the
motivation without help.

Thanks,
NeilBrown