Re: [PATCH 2/2] pinctrl: pinmux: Use dev_err_probe() in pin_request()

[Linus Walleij]

Hi Jenej,

thanks for your patch!

On Sat, Sep 9, 2023 at 8:36 AM Jernej Skrabec <jernej.skrabec@xxxxxxxxx> wrote:

> Use dev_err_probe() when printing error message in pin_request() since
> it may fail with -EPROBE_DEFER.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
(...)

>         if (status)
> -               dev_err(pctldev->dev, "pin-%d (%s) status %d\n",
> -                       pin, owner, status);
> +               dev_err_probe(pctldev->dev, "pin-%d (%s) status %d\n",
> +                             pin, owner, status);
>
>         return status;

That's not how you use dev_err_probe()

Just replace all of the lines above with return dev_err_probe(...)

Yours,
Linus Walleij