Re: [RFT PATCH 2/3] gpio: eic-sprd: use a helper variable for &pdev->dev

[Andy Shevchenko]

On Tue, Sep 12, 2023 at 11:45:18AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> Instead of dereferencing pdev everywhere, just store the address of the
> underlying struct device in a local variable.

...

> -	return devm_add_action_or_reset(&pdev->dev,
> -					sprd_eic_unregister_notifier,
> +	return devm_add_action_or_reset(dev, sprd_eic_unregister_notifier,
>  					&sprd_eic->irq_nb);

Ping-pong style detected: Lines added / modified by previous patch in the same
series got modified again.

If you look at how I do that, I introduce the temporary variable with my new
code and then reuse it later on.

OTOH, I see that the first one is supposed to be backported (?) in such case
perhaps it's fine.

-- 
With Best Regards,
Andy Shevchenko