Re: [PATCH] slab: drop unneeded NULL-pointer check in kfree auto cleanup

From: Bartosz Golaszewski
Date: Tue Sep 12 2023 - 07:26:57 EST


On Tue, Sep 12, 2023 at 12:43 PM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> On Tue, Sep 12, 2023 at 10:26:43AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > kfree() already accepts and silently ignores NULL-pointers, there's no
> > need to check it when running the auto cleanup routine.
>
> There is, because now the compiler can't help you anymore. Also see:
>
> https://lkml.kernel.org/r/169451499208.27769.5856056754166699857.tip-bot2@tip-bot2

Makes sense, thanks!

Bart