Re: [PATCH v2 09/11] gpio: acpi: replace gpiochip_find() with gpio_device_find()

From: Andy Shevchenko
Date: Tue Sep 12 2023 - 07:32:38 EST


On Tue, Sep 12, 2023 at 12:07:25PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> We're porting all users of gpiochip_find() to using gpio_device_find().
> Update the ACPI GPIO code.

...

> + /*
> + * FIXME: keep track of this reference somehow instead of putting it
> + * here.

Under "this" you meant gdev? Please, spell it explicitly, I spent a couple of
minutes to get what exactly this comment is about.

> + */
> + return gpio_device_get_desc(gdev, pin);
> }

--
With Best Regards,
Andy Shevchenko