Re: [PATCH 35/37] dt-bindings: arm: renesas: document SMARC Carrier-II EVK

[Rob Herring]

On Tue, Sep 12, 2023 at 07:51:55AM +0300, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> 
> Document Renesas SMARC Carrier-II EVK board which is based on RZ/G3S
> (R9A08G045) SoC. The SMARC Carrier-II EVK consists of RZ/G3S SoM module and
> SMARC Carrier-II carrier board, the SoM module sits on top of carrier
> board.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> index 822faf081e84..f4964445e5ab 100644
> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> @@ -476,6 +476,8 @@ properties:
>  
>        - description: RZ/G3S (R9A08G045)
>          items:
> +          - enum:
> +              - renesas,smarc2-evk # SMARC Carrier-II EVK

You just changed the existing binding...

>            - enum:
>                - renesas,r9a08g045s33 # PCIe support

This is the SoM module? You either need to squash this change or add 
another case with 3 entries and maintain the 2 entry case. (there's no 
way to express any entry at the beginning or middle can be optional)

>            - const: renesas,r9a08g045
> -- 
> 2.39.2
>