Re: [PATCH v9 0/9] x86/resctrl: Miscellaneous resctrl features

[Moger, Babu]

Hi Reinette,

On 9/11/23 18:08, Reinette Chatre wrote:
> Hi Babu,
> 
> On 9/7/2023 4:51 PM, Babu Moger wrote:
>> These series adds support few minor features.
>> 1. Support assigning multiple tasks to control/mon groups in one command.
>> 2. Add debug mount option for resctrl interface.
>> 3. Add RMID and CLOSID in resctrl interface when mounted with debug option.
>> 4. Moves the default control group creation during the mount instead of during init.
>> 5. While doing these above changes, found that rftype flags needed some cleanup.
>>    They were named inconsistently. Re-arranged them much more cleanly now and added
>>    few comments. Hope it can help future additions.
>> ---
>> v9:
>>    Changes since v8:
>>    Split the RMID display in a separate patch. RMID is a special case here as it
>>    should be printed only if monitoring is enabled.
>>    Made rdtgroup_setup_root and rdtgroup_destroy_root as static functions.
>>    Added code to print pid_str in case of task parse error.
> 
> fyi ... I found this version difficult to review. The cover letter contained this
> high level list of changes while some patches were changed without getting a mention
> here nor in patch-specific list of changes. I ended up needing to do a diff with the
> previous version to get an idea of what actually changed.

Yes. My bad. Should have listed the changes on each patch. Sure. Will do
next time.
thanks
Babu