Re: [PATCH v5 11/14] media: platform: mtk-mdp3: add mt8195 platform configuration

[Moudy Ho (何宗原)]

On Tue, 2023-09-12 at 10:21 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 12/09/2023 09:58, Moudy Ho wrote:
> > Add MT8195 MDP3 basic configuration in file "mdp_cfg_data.c"
> > and corresponding driver data.
> > 
> > Signed-off-by: Moudy Ho <moudy.ho@xxxxxxxxxxxx>
> 
> ...
> 
> >  {}
> >  };
> > diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
> b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
> > index 06b7d2b0b814..8b69bd8b91c6 100644
> > --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
> > +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
> > @@ -21,6 +21,9 @@ static const struct of_device_id mdp_of_ids[] = {
> >  { .compatible = "mediatek,mt8183-mdp3-rdma",
> >    .data = &mt8183_mdp_driver_data,
> >  },
> > +{ .compatible = "mediatek,mt8195-mdp3-rdma",
> 
> You keep adding undocumented compatibles. Your way of organizing
> patches
> does not have any sense. DTS should not be mixed with media subsystem
> -
> they *CANNOT* go via one subsystem. In the same time bindings are
> always
> going via subsystem, so why are they missing here?
> 
> This does not make any sense and such mess at v5 is confusing.
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof,


Apologize for the confusion caused by the improper separation of
patches.
This occurred because I misunderstood the new warning message
"DT_SPLIT_BINDING_PATCH: DT binding docs and includes shoulde be a
separate patch" that I received after running 'checkpatch.pl'.
I will rectify this mishandling as soon as possible.

Sincerely,
Moudy