Re: [PATCH v2 14/14] arm64: dts: qcom: sdm630: Fix USB2 clock-names order

From: Krzysztof Kozlowski
Date: Wed Sep 13 2023 - 03:19:22 EST


On 12/09/2023 15:31, Konrad Dybcio wrote:
> The last 2 clock-names entries for the USB2 controller were swapped,
> resulting in schema warnings:
>
> ['cfg_noc', 'core', 'mock_utmi', 'sleep'] is too short
> 'iface' was expected
> 'sleep' was expected
> 'mock_utmi' was expected
>
> Fix it and take the liberty to make the clock-names entries more
> readable.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sdm630.dtsi | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index f11d2a07508c..316c8fd224e0 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -1394,8 +1394,10 @@ usb2: usb@c2f8800 {
> <&gcc GCC_USB20_MASTER_CLK>,
> <&gcc GCC_USB20_MOCK_UTMI_CLK>,
> <&gcc GCC_USB20_SLEEP_CLK>;
> - clock-names = "cfg_noc", "core",
> - "mock_utmi", "sleep";
> + clock-names = "cfg_noc",
> + "core",
> + "sleep",
> + "mock_utmi";

Plus this is just incorrect... :(

Best regards,
Krzysztof