Re: [PATCH net-next] net: dsa: rtl8366rb: Implement setting up link on CPU port

[Alvin Šipraga]

On Tue, Sep 12, 2023 at 11:24:18PM +0200, Linus Walleij wrote:
> We auto-negotiate most ports in the RTL8366RB driver, but
> the CPU port is hard-coded to 1Gbit, full duplex, tx and
> rx pause.
> 
> This isn't very nice. People may configure speed and
> duplex differently in the device tree.
> 
> Actually respect the arguments passed to the function for
> the CPU port, which get passed properly after Russell's
> patch "net: dsa: realtek: add phylink_get_caps implementation"
> 
> After this the link is still set up properly.
> 
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Reviewed-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>

> ---
>  drivers/net/dsa/realtek/rtl8366rb.c | 44 +++++++++++++++++++++++++++++--------
>  1 file changed, 35 insertions(+), 9 deletions(-)