[PATCH v3] xfs: introduce protection for drop nlink

From: cheng.lin130
Date: Wed Sep 13 2023 - 05:45:04 EST


From: Cheng Lin <cheng.lin130@xxxxxxxxxx>

When abnormal drop_nlink are detected on the inode,
shutdown filesystem, to avoid corruption propagation.

Signed-off-by: Cheng Lin <cheng.lin130@xxxxxxxxxx>
---
fs/xfs/xfs_inode.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 9e62cc500..40cc106ae 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -919,6 +919,15 @@ xfs_droplink(
xfs_trans_t *tp,
xfs_inode_t *ip)
{
+
+ if (VFS_I(ip)->i_nlink == 0) {
+ xfs_alert(ip->i_mount,
+ "%s: Deleting inode %llu with no links.",
+ __func__, ip->i_ino);
+ tp->t_flags |= XFS_TRANS_DIRTY;
+ return -EFSCORRUPTED;
+ }
+
xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG);

drop_nlink(VFS_I(ip));
--
2.18.1