Re: [PATCH 2/5] selftests/resctrl: Remove duplicate feature check from CMT test

From: Ilpo Järvinen
Date: Wed Sep 13 2023 - 07:12:59 EST


On Tue, 12 Sep 2023, Reinette Chatre wrote:
> On 9/11/2023 4:19 AM, Ilpo Järvinen wrote:
> > The test runner run_cmt_test() in resctrl_tests.c checks for CMT
> > feature and does not run cmt_resctrl_val() if CMT is not supported.
> > Then cmt_resctrl_val() also check is CMT is supported.
> >
> > Remove the duplicated feature check for CMT from cmt_resctrl_val().
> >
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> > Cc: <stable@xxxxxxxxxxxxxxx>
>
> This does not look like stable material to me.

I know but when constructing this series I had 2 options:

Either convert also this when changing validate_resctrl_feature_request()
or remove this call entirely.

Given it's duplicate of the other CMT check, I chose to just remove it
(which I'd do anyway). As patch 4/5 requires 3/5 which in turn requires
this, this has to go stable if 4/5 goes too.

--
i.