Re: [PATCH v4 3/3] drm/panel-simple: allow LVDS format override

From: Johannes Zink
Date: Wed Sep 13 2023 - 07:25:24 EST


Hi Dan,

On 9/13/23 13:14, Dan Carpenter wrote:
On Fri, Aug 18, 2023 at 09:04:34AM +0200, Johannes Zink wrote:
Hi Dan,

do you have any input on this for me?


Sorry, I was out of office and the truth is that I'm never going to
catch up on all the email I missed. :/


nevermind, that's why I sent ping...

Looks okay to me. I can't remember what I said about this code in v3
but it looks good now. I'm not a DRM dev so I'm not sure my review
counts for much.

IIRC it was a mistake I made with a return value that I have fixed in v4.

You should always just assume that if I'm quiet
then I'm happy. :)

That's good to know ;-) Thanks for your review!

Johannes


regards,
dan carpenter



--
Pengutronix e.K. | Johannes Zink |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |