Re: [PATCH 2/4] nvmet: Add polling queue task for nvme target
From: kernel test robot
Date: Wed Sep 13 2023 - 08:19:30 EST
Hi Ping,
kernel test robot noticed the following build warnings:
[auto build test WARNING on v6.6-rc1]
[also build test WARNING on linus/master next-20230913]
[cannot apply to hch-configfs/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ping-Gan/nvmet-Add-nvme-target-polling-queue-task-parameters/20230913-164112
base: v6.6-rc1
patch link: https://lore.kernel.org/r/84d7f188e892b5b0ba251a4601455d7a137075f3.1694592708.git.jacky_gam_2001%40163.com
patch subject: [PATCH 2/4] nvmet: Add polling queue task for nvme target
config: arc-randconfig-r004-20230913 (https://download.01.org/0day-ci/archive/20230913/202309131959.1zH6sjmk-lkp@xxxxxxxxx/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230913/202309131959.1zH6sjmk-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309131959.1zH6sjmk-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/nvme/target/polling-queue-thread.c: In function '__nvmet_pq_ring_do_enqueue':
>> drivers/nvme/target/polling-queue-thread.c:150:37: warning: this statement may fall through [-Wimplicit-fallthrough=]
150 | ring[idx++] = obj_table[i++]; /* fallthrough */ \
| ~~~~~~~~~~~~^~~~~~~~~~~~~~~~
drivers/nvme/target/polling-queue-thread.c:278:9: note: in expansion of macro 'ENQUEUE_PTRS'
278 | ENQUEUE_PTRS(r, &r[1], prod_head, obj_table, n, void *);
| ^~~~~~~~~~~~
drivers/nvme/target/polling-queue-thread.c:151:17: note: here
151 | case 2: \
| ^~~~
drivers/nvme/target/polling-queue-thread.c:278:9: note: in expansion of macro 'ENQUEUE_PTRS'
278 | ENQUEUE_PTRS(r, &r[1], prod_head, obj_table, n, void *);
| ^~~~~~~~~~~~
drivers/nvme/target/polling-queue-thread.c:152:37: warning: this statement may fall through [-Wimplicit-fallthrough=]
152 | ring[idx++] = obj_table[i++]; /* fallthrough */ \
| ~~~~~~~~~~~~^~~~~~~~~~~~~~~~
drivers/nvme/target/polling-queue-thread.c:278:9: note: in expansion of macro 'ENQUEUE_PTRS'
278 | ENQUEUE_PTRS(r, &r[1], prod_head, obj_table, n, void *);
| ^~~~~~~~~~~~
drivers/nvme/target/polling-queue-thread.c:153:17: note: here
153 | case 1: \
| ^~~~
drivers/nvme/target/polling-queue-thread.c:278:9: note: in expansion of macro 'ENQUEUE_PTRS'
278 | ENQUEUE_PTRS(r, &r[1], prod_head, obj_table, n, void *);
| ^~~~~~~~~~~~
drivers/nvme/target/polling-queue-thread.c: In function '__nvmet_pq_ring_do_dequeue':
drivers/nvme/target/polling-queue-thread.c:181:40: warning: this statement may fall through [-Wimplicit-fallthrough=]
181 | obj_table[i++] = ring[idx++]; /* fallthrough */ \
| ^
drivers/nvme/target/polling-queue-thread.c:298:9: note: in expansion of macro 'DEQUEUE_PTRS'
298 | DEQUEUE_PTRS(r, &r[1], cons_head, obj_table, n, void *);
| ^~~~~~~~~~~~
drivers/nvme/target/polling-queue-thread.c:182:17: note: here
182 | case 2: \
| ^~~~
drivers/nvme/target/polling-queue-thread.c:298:9: note: in expansion of macro 'DEQUEUE_PTRS'
298 | DEQUEUE_PTRS(r, &r[1], cons_head, obj_table, n, void *);
| ^~~~~~~~~~~~
drivers/nvme/target/polling-queue-thread.c:183:40: warning: this statement may fall through [-Wimplicit-fallthrough=]
183 | obj_table[i++] = ring[idx++]; /* fallthrough */ \
| ^
drivers/nvme/target/polling-queue-thread.c:298:9: note: in expansion of macro 'DEQUEUE_PTRS'
298 | DEQUEUE_PTRS(r, &r[1], cons_head, obj_table, n, void *);
| ^~~~~~~~~~~~
drivers/nvme/target/polling-queue-thread.c:184:17: note: here
184 | case 1: \
| ^~~~
drivers/nvme/target/polling-queue-thread.c:298:9: note: in expansion of macro 'DEQUEUE_PTRS'
298 | DEQUEUE_PTRS(r, &r[1], cons_head, obj_table, n, void *);
| ^~~~~~~~~~~~
vim +150 drivers/nvme/target/polling-queue-thread.c
131
132 //below is derived from FreeBSD's bufring.h
133 /* the actual enqueue of pointers on the ring.
134 * Placed here since identical code needed in both
135 * single and multi producer enqueue functions */
136 #define ENQUEUE_PTRS(r, ring_start, prod_head, obj_table, n, obj_type) do { \
137 unsigned int i; \
138 const u32 size = (r)->size; \
139 u32 idx = prod_head & (r)->mask; \
140 obj_type *ring = (obj_type *)ring_start; \
141 if (likely(idx + n < size)) { \
142 for (i = 0; i < (n & ((~(unsigned)0x3))); i += 4, idx += 4) { \
143 ring[idx] = obj_table[i]; \
144 ring[idx+1] = obj_table[i+1]; \
145 ring[idx+2] = obj_table[i+2]; \
146 ring[idx+3] = obj_table[i+3]; \
147 } \
148 switch (n & 0x3) { \
149 case 3: \
> 150 ring[idx++] = obj_table[i++]; /* fallthrough */ \
151 case 2: \
152 ring[idx++] = obj_table[i++]; /* fallthrough */ \
153 case 1: \
154 ring[idx++] = obj_table[i++]; \
155 } \
156 } else { \
157 for (i = 0; idx < size; i++, idx++)\
158 ring[idx] = obj_table[i]; \
159 for (idx = 0; i < n; i++, idx++) \
160 ring[idx] = obj_table[i]; \
161 } \
162 } while (0)
163
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki