RE: [PATCH] Revert "EDAC/mce_amd: Do not load edac_mce_amd module on guests"

From: Luck, Tony
Date: Wed Sep 13 2023 - 11:50:43 EST


> Also, please note that the EDAC modules don't handle MCE events
> directly. They act on information passed from the MCE subsystem.
>
> Furthermore, there are other EDAC modules that have the same !hypervisor
> check, so why change only this one?

The older Intel EDAC drivers translated system physical addresses to DIMM
addresses by digging around in the CONFIG and MMIO space of the memory
controller devices. It would seem unwise for a VMM to give access to those
addresses to a guest (in general ... perhaps OK for a Xen style "DOM0" guest that is
handling many tasks for the VMM?).

What system resources do AMD EDAC drivers need access to? Could they
work inside a guest?

-Tony