Re: [PATCH 15/15] kasan: use stack_depot_evict for tag-based modes

From: Andrey Konovalov
Date: Wed Sep 13 2023 - 13:09:02 EST


On Mon, Sep 4, 2023 at 8:59 PM Marco Elver <elver@xxxxxxxxxx> wrote:
>
> >
> > Hm, I actually suspect we don't need these READ/WRITE_ONCE to entry
> > fields at all. This seems to be a leftover from the initial series
> > when I didn't yet have the rwlock. The rwlock prevents the entries
> > from being read (in kasan_complete_mode_report_info) while being
> > written and the try_cmpxchg prevents the same entry from being
> > rewritten (in the unlikely case of wrapping during writing).
> >
> > Marco, do you think we can drop these READ/WRITE_ONCE?
>
> Yes, I think they can be dropped.

Will drop in v2, thanks!