Re: [[RFC PATCH v4 net-next] 0/2] net: dsa: hsr: Enable HSR HW offloading for KSZ9477

From: Vladimir Oltean
Date: Wed Sep 13 2023 - 14:42:15 EST


On Wed, Sep 13, 2023 at 04:51:02PM +0300, Vladimir Oltean wrote:
> > I'm really stunned, how much extra work is required to add two
> > callbacks to DSA subsystem (to have already implemented feature) for a
> > single chip IC.
>
> Some observations are best kept to yourself. This is only the second HSR
> offload in the entire kernel. To complain that the infrastructure needs
> some extensions, for something that wasn't even needed for the first
> implementation (tracking a MAC address), is unrealistic.

Can you please test the attached incremental patch, which applies on top
of your RFC v4 series? It contains an implementation of my own review feedback.