Re: [GIT PULL] tpmdd changes for v6.6-rc2

From: Jarkko Sakkinen
Date: Wed Sep 13 2023 - 15:54:50 EST


On Wed Sep 13, 2023 at 10:45 PM EEST, Linus Torvalds wrote:
> On Wed, 13 Sept 2023 at 12:32, Jarkko Sakkinen <jarkko@xxxxxxxxxx> wrote:
> >
> > Ok, I'll make something more reasonable.
>
> Well, I took the pull already, just saying "tpm fix".
>
> I assume the only thing the typo actually causes is printk's with a
> typo in it. Maybe some sysfs name will be wrong?
>
> That's the kind of information I would have _liked_ to see in the
> merge message, but I didn't then delve into just where the class names
> might actually be used.
>
> Linus

Thanks for pointing this out because I also overlooked the whole fix,
and based my conclusions just "git describe --contains", which pointed
to my previous signed tag.

I actually do QA (both x86 and aarch64 and slowly setting up also riscv)
to my tree, and I did not understand how this could have leaked into a
PR since TPM2 kselftest would have catched that.

The original commit must have gone through some other maintainer tree
since I do not see in any of my PR's. Anyway, I'll document next time
better my PR because apparently not doing that can lead to toally false
conclusions :-)

Thanks for picking it up anyway.

BR, Jarkko