Re: [PATCH 08/19] pstore: shrink the pstore_sb_lock critical section in pstore_kill_sb

From: Kees Cook
Date: Wed Sep 13 2023 - 18:07:30 EST


On Wed, Sep 13, 2023 at 08:10:02AM -0300, Christoph Hellwig wrote:
> ->kill_sb can't race with creating ->fill_super because pstore is a
> _single file system that only ever has a single sb instance, and we wait
> for the previous one to go away before creating a new one. Reduce
> the critical section so that is is not held over generic_shutdown_super.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Thanks for the refactoring!

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook