Re: [PATCH 2/2] checkpatch: Add a couple new alloc functions to alloc with multiplies check

From: Joe Perches
Date: Wed Sep 13 2023 - 19:00:41 EST


On Wed, 2023-09-13 at 16:41 -0600, Gustavo A. R. Silva wrote:
>
> On 9/13/23 16:34, Joe Perches wrote:
> > On Wed, 2023-09-13 at 16:32 -0600, Gustavo A. R. Silva wrote:
> > >
> > > On 9/13/23 16:25, Joe Perches wrote:
> > > > On Wed, 2023-09-13 at 16:14 -0600, Gustavo A. R. Silva wrote:
> > > > >
> > > > > On 9/13/23 14:37, Joe Perches wrote:
> > > > > > vmalloc() and vzalloc() functions have now 2-factor multiplication
> > > > > > argument forms vmalloc_array() and vcalloc(), correspondingly.
> > > > > >
> > > > > > Add alloc-with-multiplies checks for these new functions.
> > > > > >
> > > > > > Simplify the original codes repeated else to use a hash.
> > > > > >
> > > > > > Link: https://github.com/KSPP/linux/issues/342
> > > > > >
> > > > > > Original-patch-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> > > > >
> > > > > Why don't you wait for a response or a v2 from the original
> > > > > submitter?
> > > >
> > > > Because there really is no need to wait.
> > >
> > > By the way, did you test it?
> >
> > Yes, against arch/s390/include/asm/idals.h
>
> I don't see any instances of vmalloc() or vzalloc() in that file.

<snort> Cute.

Missing a ? in the original search '\s*,?'
or just its removal...

Likely the removal would be better.

thanks, cheers, Joe