Re: [PATCH v3 6/6] scsi: ipr: Do PCI error checks on own line

From: Martin K. Petersen
Date: Wed Sep 13 2023 - 21:06:20 EST

Next message: Sean Christopherson: "[PATCH] KVM: selftests: Assert that vasprintf() is successful"
Previous message: kernel test robot: "[tip:x86/tdx 8/12] vmlinux.o: warning: objtool: __tdx_hypercall+0x128: __tdx_hypercall_failed() is missing a __noreturn annotation"
In reply to: Ilpo Järvinen: "[PATCH v3 6/6] scsi: ipr: Do PCI error checks on own line"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Ilpo,

> Instead of if conditions with line splits, use the usual error handling
> pattern with a separate variable to improve readability.
>
> No functional changes intended.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

--
Martin K. Petersen Oracle Linux Engineering

Next message: Sean Christopherson: "[PATCH] KVM: selftests: Assert that vasprintf() is successful"
Previous message: kernel test robot: "[tip:x86/tdx 8/12] vmlinux.o: warning: objtool: __tdx_hypercall+0x128: __tdx_hypercall_failed() is missing a __noreturn annotation"
In reply to: Ilpo Järvinen: "[PATCH v3 6/6] scsi: ipr: Do PCI error checks on own line"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]