Re: [PATCH] scsi: ufs: qcom: dt-bindings: Add MCQ ESI property

[Ziqi Chen]

Hi Krzysztof，

Thanks for your comment very much ~
I will remove this property in next patch version.
We just plan to post "msi-parent" property for MCQ.


Best Regards,
Ziqi

On 9/11/2023 2:27 PM, Krzysztof Kozlowski wrote:
> On 08/09/2023 10:53, Ziqi Chen wrote:
> > Document the description for the qcom,esi-affinity-mask.
>
> This tells me nothing what is this feature for.
>
> > Signed-off-by: Ziqi Chen <quic_ziqichen@xxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > index bdfa86a..323595f 100644
> > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > @@ -97,6 +97,10 @@ properties:
> >       description:
> >         GPIO connected to the RESET pin of the UFS memory device.
> >   
> > +  qcom,esi-affinity-mask:
>
> Not tested. You also miss proper type.
>
> > +    description:
> > +       UFS MCQ ESI affinity mask. Affine ESI on registration according to this CPU mask.
>
> And why is this a property of DT? Aren't you now describing driver?
>
>
>
> Best regards,
> Krzysztof