Re: [PATCH 13/19] fs: convert kill_block_super to block_free_sb

From: Al Viro
Date: Wed Sep 13 2023 - 22:30:45 EST


On Wed, Sep 13, 2023 at 08:10:07AM -0300, Christoph Hellwig wrote:

> -static void affs_kill_sb(struct super_block *sb)
> +static void affs_free_sb(struct super_block *sb)
> {
> struct affs_sb_info *sbi = AFFS_SB(sb);
> - kill_block_super(sb);
> +
> + block_free_sb(sb);
> if (sbi) {
> affs_free_bitmap(sb);
> affs_brelse(sbi->s_root_bh);

<checks>

Yep, that's printk + brelse()... Could we have that
block_free_sb() (an awful name aside) done after the
if (sbi) { ... } there?