Re: [PATCH] Documentation: kbuild: explain handling optional dependencies

[Nicolas Schier]

On Wed 13 Sep 2023 23:16:47 GMT, Arnd Bergmann wrote:
> On Wed, Sep 13, 2023, at 22:34, Nicolas Schier wrote:
> > On Wed, Sep 13, 2023 at 09:55:36PM +0200 Arnd Bergmann wrote:
> 
> >>    config FOO
> >> -       bool "Support for foo hardware"
> >> +       tristate "Support for foo hardware"
> >>         depends on BAR || !BAR
> >
> > ah, thanks, tristate kconfig symbols are really more interesting.  But I am
> > still not sure, whether this works as proposed:
> >
> > With the 'config FOO' above and
> >
> >   config BAR
> >   	tristate "Support for bar feature"
> >
> > kconfig allows me to choose between these:
> >
> > BAR=y  => FOO={N/m/y}
> > BAR=m  => FOO={N/m}
> > BAR=n  => FOO={N/m/y}
> >
> > But with
> >
> >   config FOO
> >   	tristate "Support for foo hardware"
> >   	depends on !BAR=m
> >
> > I can choose between:
> >
> > BAR=y  => FOO={N/m/y}
> > BAR=m  => FOO is not selectable
> > BAR=n  => FOO={N/m/y}
> 
> That is indeed the point: if BAR=m, we want to be able to pick FOO=m
> here, otherwise it is impossible to enabled everything as modules.

oh, I misinterpreted your very first sentence; thanks for clarifying it to me
and sorry for the noise.
With the minor fixes:

Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx>

Kind regards,
Nicolas

Attachment: signature.asc
Description: PGP signature