Re: [PATCH 1/4] dt-bindings: serial: document esp32-uart bindings

From: Krzysztof Kozlowski
Date: Thu Sep 14 2023 - 01:55:43 EST


On 13/09/2023 23:14, Max Filippov wrote:
> Add documentation for the ESP32xx UART controllers.
>
> Signed-off-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
> ---
> .../bindings/serial/esp,esp32-uart.yaml | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/serial/esp,esp32-uart.yaml
>
> diff --git a/Documentation/devicetree/bindings/serial/esp,esp32-uart.yaml b/Documentation/devicetree/bindings/serial/esp,esp32-uart.yaml
> new file mode 100644
> index 000000000000..8b45ef808107
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/esp,esp32-uart.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serial/esp,esp32-uart.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ESP32 UART controller
> +
> +maintainers:
> + - Max Filippov <jcmvbkbc@xxxxxxxxx>
> +
> +description: |
> + ESP32 UART controller is a part of ESP32 SoC series.

1. Company name?
2. ESP32 SoC series suggests esp32 is a series.

> +
> +properties:
> + compatible:
> + oneOf:
> + - description: UART controller for the ESP32 SoC
> + const: esp,esp32-uart

Also, the vendor prefix looks incorrect, so again - what is the company
name?

Best regards,
Krzysztof