Re: [PATCH v3] x86/platform/uv: refactor deprecated strcpy and strncpy

From: Ingo Molnar
Date: Thu Sep 14 2023 - 02:30:39 EST



* Hans de Goede <hdegoede@xxxxxxxxxx> wrote:

> >> Which IMHO is much more readable then what has landed now. But since
> >> v2 has already landed I guess the best thing is just to stick with
> >> what we have upstream now...
> >
> > Well, how about we do a delta patch with all the changes you suggested?
> > I'm all for readability.
>
> So I started doing this and notices that all the string manipulation +
> parsing done here is really just a DYI implementation of
> sysfs_match_string().
>
> So I have prepared a patch to switch to sysfs_match_string(), which
> completely removes the need to make a copy of the val string.
>
> I'll submit the patch right after this email.

Thank you - that looks a far more thorough cleanup indeed.

Ingo