Re: [RFC PATCH v2 3/4] staging: vc04: Convert vchiq_log_info() to use dynamic debug

From: Dan Carpenter
Date: Thu Sep 14 2023 - 02:38:09 EST

Next message: John Garry: "Re: [PATCH v3 1/3] perf pmu: Move pmu__find_core_pmu() to pmus.c"
Previous message: Shengjiu Wang: "[RFC PATCH v3 8/9] media: audm2m: add virtual driver for audio memory to memory"
In reply to: Umang Jain: "[RFC PATCH v2 3/4] staging: vc04: Convert vchiq_log_info() to use dynamic debug"
Next in thread: Umang Jain: "[RFC PATCH v2 4/4] staging: vc04: Convert vchiq_log_trace() to use dynamic debug"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Please rename vchiq_log_info() to vchiq_log_dbg() or something. When I
see "info", I think it's a KERN_INFO level. This is all debug stuff and
it's done correctly but the name is misleading so it looks wrong.

regards,
dan carpenter

Next message: John Garry: "Re: [PATCH v3 1/3] perf pmu: Move pmu__find_core_pmu() to pmus.c"
Previous message: Shengjiu Wang: "[RFC PATCH v3 8/9] media: audm2m: add virtual driver for audio memory to memory"
In reply to: Umang Jain: "[RFC PATCH v2 3/4] staging: vc04: Convert vchiq_log_info() to use dynamic debug"
Next in thread: Umang Jain: "[RFC PATCH v2 4/4] staging: vc04: Convert vchiq_log_trace() to use dynamic debug"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]