Re: [PATCH v4 1/3] sched/uclamp: Set max_spare_cap_cpu even if max_spare_cap is 0

From: Ingo Molnar
Date: Thu Sep 14 2023 - 02:39:51 EST



* Qais Yousef <qyousef@xxxxxxxxxxx> wrote:

> > Reviewed-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
>
> Thanks for the review!
>
> I will wait for the maintainers to see if they would like a v5 to address
> the nitpicks or it's actually good enough and happy to pick this up. I
> think the commit messages explain the problem clear enough and doesn't
> warrant sending a new version. But happy to do so if there's insistence
> :-)

Yeah, please always do that: sensible review replies with actionable
feedback cause a semi-atomatic "mark this thread as read, there will be a
next version" reflexive action from maintainers, especially if a series is
in its 4th iteration already...

Thanks,

Ingo