Re: [PATCH v2] x86/platform/uv: Rework NMI "action" modparam handling

[Andy Shevchenko]

On Thu, Sep 14, 2023 at 11:42 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Wed, Sep 13, 2023 at 9:01 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:

...

> > -       pr_err("UV: Invalid NMI action:%s, valid actions are:\n", arg);
> > +       pr_err("UV: Invalid NMI action:%s, valid actions are:\n", val);
>
> As mentioned previously the val may or may not have a new line in it.
> I dunno about comma removal, but a new line presence can be easily checked.
>
> Either way it's not so critical, hence removing comma. or replacing it
> by '-' (dash) may be enough.

Or even

       pr_err("UV: Invalid NMI action:%s --> valid actions are:\n", val);


-- 
With Best Regards,
Andy Shevchenko