Re: [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support

[Nitin Yadav]

Hi Krzysztof,

On 14/09/23 11:57, Krzysztof Kozlowski wrote:
> On 13/09/2023 13:47, Nitin Yadav wrote:
>> Add support for AM62Q NAND card: X8 NAND EXPANSION
>> BOARD card (PROC143E1) for AM62x LP SK board.
>>
>> Signed-off-by: Nitin Yadav <n-yadav@xxxxxx>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++
>>  arch/arm64/boot/dts/ti/k3-am62.dtsi      |  2 ++
>>  2 files changed, 31 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> index 284b90c94da8..e93e79d8083f 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> @@ -955,4 +955,33 @@ mcasp2: audio-controller@2b20000 {
>>  		power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
>>  		status = "disabled";
>>  	};
>> +	gpmc0: memory-controller@3b000000 {
>> +		status = "disabled";
> 
> status is never first in DTSI. Really, where did you see such code?
Thank for pointing out, Will send a revised version.
> 
>> +		compatible = "ti,am64-gpmc";
>> +		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
> 
> First is compatible, second is reg/reg-names/ranges.
> 
> 
> Best regards,
> Krzysztof
> 

-- 
Regards,
Nitin