Re: [PATCH 13/17] pmdomain: starfive: Move Kconfig file to the pmdomain subsystem

[Conor Dooley]

Hey,


On Thu, Sep 14, 2023 at 01:19:04PM +0200, Ulf Hansson wrote:
> The Kconfig belongs closer to the corresponding implementation, hence let's
> move it from the soc subsystem to the pmdomain subsystem.
> 
> Cc: Walker Chen <walker.chen@xxxxxxxxxxxxxxxx>
> Cc: Conor Dooley <conor@xxxxxxxxxx>
> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Thanks for doing this, saved me having to!
The series appears to have broken threading though, which can be seen
pretty easily on lore:
https://lore.kernel.org/all/20230914111904.586744-1-ulf.hansson@xxxxxxxxxx/
Dunno if something is borked with your process while sending patches to
only a subset of the total recipient list.

> ---
>  MAINTAINERS                                | 2 +-
>  drivers/pmdomain/Kconfig                   | 1 +
>  drivers/{soc => pmdomain}/starfive/Kconfig | 0
>  drivers/soc/Kconfig                        | 1 -
>  4 files changed, 2 insertions(+), 2 deletions(-)
>  rename drivers/{soc => pmdomain}/starfive/Kconfig (100%)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6b491ebcf790..b8eae18f0fb1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20523,7 +20523,7 @@ M:	Conor Dooley <conor@xxxxxxxxxx>
>  S:	Maintained
>  T:	git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/
>  F:	Documentation/devicetree/bindings/soc/starfive/
> -F:	drivers/soc/starfive/
> +F:	drivers/pmdomain/starfive/

This isn't the correct change, just remove the drivers/soc/starfive
bit entirely from this entry. 
I've just been doing some review & sending PRs to Arnd for this stuff
(or failing to send the PRs as you saw), I don't have particular
interest in this driver other than helping out the starfive people with
actually getting the code merged.
Instead I think you should generalise the existing entry for the driver
to cover the whole directory, so that it includes the Kconfig bits too:

diff --git a/MAINTAINERS b/MAINTAINERS
index fa7487b7729b..22c1a5e5b130 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20564,7 +20564,7 @@ M:      Walker Chen <walker.chen@xxxxxxxxxxxxxxxx>
 M:     Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
 S:     Supported
 F:     Documentation/devicetree/bindings/power/starfive*
-F:     drivers/pmdomain/starfive/jh71xx-pmu.c
+F:     drivers/pmdomain/starfive/
 F:     include/dt-bindings/power/starfive,jh7110-pmu.h
 
 STARFIVE SOC DRIVERS

Thanks,
Conor.

>  
>  STARFIVE TRNG DRIVER
>  M:	Jia Jie Ho <jiajie.ho@xxxxxxxxxxxxxxxx>
> diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig
> index cfe9ea754062..67049ebf7265 100644
> --- a/drivers/pmdomain/Kconfig
> +++ b/drivers/pmdomain/Kconfig
> @@ -12,5 +12,6 @@ source "drivers/pmdomain/renesas/Kconfig"
>  source "drivers/pmdomain/rockchip/Kconfig"
>  source "drivers/pmdomain/samsung/Kconfig"
>  source "drivers/pmdomain/st/Kconfig"
> +source "drivers/pmdomain/starfive/Kconfig"
>  
>  endmenu
> diff --git a/drivers/soc/starfive/Kconfig b/drivers/pmdomain/starfive/Kconfig
> similarity index 100%
> rename from drivers/soc/starfive/Kconfig
> rename to drivers/pmdomain/starfive/Kconfig
> diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig
> index 8b46da40f107..10a9ff84ff41 100644
> --- a/drivers/soc/Kconfig
> +++ b/drivers/soc/Kconfig
> @@ -23,7 +23,6 @@ source "drivers/soc/renesas/Kconfig"
>  source "drivers/soc/rockchip/Kconfig"
>  source "drivers/soc/samsung/Kconfig"
>  source "drivers/soc/sifive/Kconfig"
> -source "drivers/soc/starfive/Kconfig"
>  source "drivers/soc/sunxi/Kconfig"
>  source "drivers/soc/tegra/Kconfig"
>  source "drivers/soc/ti/Kconfig"
> -- 
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature