Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path

[Guillaume Ranquet]

On Thu, 14 Sep 2023 15:10, Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
>Setting new_edid to NULL leaks the buffer.
>
>Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
>Cc: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
>Cc: Guillaume Ranquet <granquet@xxxxxxxxxxxx>
>Cc: Bo-Chen Chen <rex-bc.chen@xxxxxxxxxxxx>
>Cc: CK Hu <ck.hu@xxxxxxxxxxxx>
>Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
>Cc: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>
>Cc: Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx>
>Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
>Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx>
>Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
>Cc: linux-mediatek@xxxxxxxxxxxxxxxxxxx
>Cc: linux-kernel@xxxxxxxxxxxxxxx
>Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>Cc: <stable@xxxxxxxxxxxxxxx> # v6.1+
>Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>

Reviewed-by: Guillaume Ranquet <granquet@xxxxxxxxxxxx>
>---
>
>UNTESTED
>---
> drivers/gpu/drm/mediatek/mtk_dp.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
>index 2cb47f663756..8fc6eff68e30 100644
>--- a/drivers/gpu/drm/mediatek/mtk_dp.c
>+++ b/drivers/gpu/drm/mediatek/mtk_dp.c
>@@ -2049,6 +2049,7 @@ static struct edid *mtk_dp_get_edid(struct drm_bridge *bridge,
> 	 */
> 	if (mtk_dp_parse_capabilities(mtk_dp)) {
> 		drm_err(mtk_dp->drm_dev, "Can't parse capabilities\n");
>+		kfree(new_edid);
> 		new_edid = NULL;
> 	}
>
>--
>2.39.2
>