Re: [PATCH 2/5] mtd: rawnand: ingenic: use gpiod_set_active_high()
From: Linus Walleij
Date: Thu Sep 14 2023 - 09:55:37 EST
On Thu, Sep 14, 2023 at 11:30 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> On Thu, Sep 14, 2023 at 10:30 AM Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote:
> > > I believe Linus was for moving.
Yes.
> > Which Linus? Because the one who's also the gpio maintainer just wrote
> > above that it was better to keep it in the driver.
What. No. I expressed myself unclearly:
> > Why not moving this quirk to gpiolib-of.c?
>
> That's a better idea here I think, it's clearly a quirk for a
> buggy device tree.
"That's a better idea here I think"
means
"That's a better idea [IN THIS CASE] I think"
i.e. in this case it is a better idea to move it into gpiolib-of.c
> I'm also under the impression that Linus meant moving it to gpiolib-of.c. Let's
>
> Linus: Could you clarify?
Yes.
I invented that thing so I'm a fan of it.
Yours,
Linus Walleij