Re: [PATCH v2 1/4] dt-bindings: phy: qcom,snps-eusb2-repeater: Add magic tuning overrides

From: Rob Herring
Date: Thu Sep 14 2023 - 10:48:16 EST


On Wed, Sep 13, 2023 at 11:53:23AM +0200, Konrad Dybcio wrote:
> The EUSB2 repeater requires some alterations to its init sequence,
> depending on board design.
>
> Add support for making the necessary changes to that sequence to make USB
> functional on SM8550-based Xperia 1 V.
>
> They all have lackluster description due to lack of information.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> .../bindings/phy/qcom,snps-eusb2-repeater.yaml | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> index 029569d5fcf3..24c733c10e0e 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> @@ -32,6 +32,27 @@ properties:
>
> vdd3-supply: true
>
> + qcom,tune-usb2-disc-thres:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + description: High-Speed disconnect threshold
> + minimum: 0
> + maximum: 7
> + default: 0
> +
> + qcom,tune-usb2-amplitude:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + description: High-Speed trasmit amplitude
> + minimum: 0
> + maximum: 15
> + default: 8
> +
> + qcom,tune-usb2-preem:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + description: High-Speed TX pre-emphasis tuning
> + minimum: 0
> + maximum: 7
> + default: 5

For what it is worth, the mediatek,tphy.yaml binding has the same
properties...

Acked-by: Rob Herring <robh@xxxxxxxxxx>