Re: [PATCH 14/17] pmdomain: sunxi: Move Kconfig option to the pmdomain subsystem

[Jernej Škrabec]

Dne četrtek, 14. september 2023 ob 13:19:12 CEST je Ulf Hansson napisal(a):
> The Kconfig option belongs closer to the corresponding implementation,
> hence let's move it from the soc subsystem to the pmdomain subsystem.
> 
> Cc: Chen-Yu Tsai <wens@xxxxxxxx>
> Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> Cc: Samuel Holland <samuel@xxxxxxxxxxxx>
> Cc: <linux-sunxi@xxxxxxxxxxxxxxx>
> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>

Best regards,
Jernej

> ---
>  drivers/pmdomain/Kconfig       |  1 +
>  drivers/pmdomain/sunxi/Kconfig | 10 ++++++++++
>  drivers/soc/sunxi/Kconfig      |  9 ---------
>  3 files changed, 11 insertions(+), 9 deletions(-)
>  create mode 100644 drivers/pmdomain/sunxi/Kconfig
> 
> diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig
> index 67049ebf7265..39f358f27f2e 100644
> --- a/drivers/pmdomain/Kconfig
> +++ b/drivers/pmdomain/Kconfig
> @@ -13,5 +13,6 @@ source "drivers/pmdomain/rockchip/Kconfig"
>  source "drivers/pmdomain/samsung/Kconfig"
>  source "drivers/pmdomain/st/Kconfig"
>  source "drivers/pmdomain/starfive/Kconfig"
> +source "drivers/pmdomain/sunxi/Kconfig"
> 
>  endmenu
> diff --git a/drivers/pmdomain/sunxi/Kconfig b/drivers/pmdomain/sunxi/Kconfig
> new file mode 100644
> index 000000000000..17781bf8d86d
> --- /dev/null
> +++ b/drivers/pmdomain/sunxi/Kconfig
> @@ -0,0 +1,10 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config SUN20I_PPU
> +	bool "Allwinner D1 PPU power domain driver"
> +	depends on ARCH_SUNXI || COMPILE_TEST
> +	depends on PM
> +	select PM_GENERIC_DOMAINS
> +	help
> +	  Say y to enable the PPU power domain driver. This saves power
> +	  when certain peripherals, such as the video engine, are idle.
> diff --git a/drivers/soc/sunxi/Kconfig b/drivers/soc/sunxi/Kconfig
> index c5070914fc6a..8aecbc9b1976 100644
> --- a/drivers/soc/sunxi/Kconfig
> +++ b/drivers/soc/sunxi/Kconfig
> @@ -19,12 +19,3 @@ config SUNXI_SRAM
>  	  Say y here to enable the SRAM controller support. This
>  	  device is responsible on mapping the SRAM in the sunXi SoCs
>  	  whether to the CPU/DMA, or to the devices.
> -
> -config SUN20I_PPU
> -	bool "Allwinner D1 PPU power domain driver"
> -	depends on ARCH_SUNXI || COMPILE_TEST
> -	depends on PM
> -	select PM_GENERIC_DOMAINS
> -	help
> -	  Say y to enable the PPU power domain driver. This saves power
> -	  when certain peripherals, such as the video engine, are idle.