Re: [PATCH v2] x86/platform/uv: Rework NMI "action" modparam handling
From: Steve Wahl
Date: Thu Sep 14 2023 - 11:16:25 EST
On Wed, Sep 13, 2023 at 04:06:51PM -0500, Steve Wahl wrote:
> On Wed, Sep 13, 2023 at 08:01:11PM +0200, Hans de Goede wrote:
> Maybe rework the message so a possible newline doesn't look so
> awkward, by removing the comma?
>
> > + pr_err("UV: Invalid NMI action:%s Valid actions are:\n", val);
It occurred to me overnight that leaving val out completely is an
option, as printing it adds very little value. So a reasonable option
would be:
+ pr_err("UV: Invalid NMI action. Valid actions are:\n");
--> Steve
--
Steve Wahl, Hewlett Packard Enterprise