Re: [PATCH v4 2/5] riscv: Add checksum library

From: Conor Dooley
Date: Thu Sep 14 2023 - 14:02:37 EST


> > > +#ifndef CONFIG_32BIT
> >
> > These can also be moved to IS_ENABLED() FYI, since there's no 32-bit
> > stuff here that'd break the build for 64-bit. Ditto elsewhere where
> > you've got similar stuff.
> >
> > Cheers,
> > Conor.
> This is an ifndef, so 32-bit compilation would throw a warning about
> shifting by 32 bits if IS_ENABLED was used instead.

Fair enough. I did accidentally invert things in my mail, I did notice
the n, I just thought it did the elimination beforehand those checks,
sorry for the noise.

Attachment: signature.asc
Description: PGP signature