Re: [PATCH 2/3] userfaultfd: UFFDIO_REMAP uABI
From: Suren Baghdasaryan
Date: Thu Sep 14 2023 - 14:54:58 EST
On Thu, Sep 14, 2023 at 11:47 AM David Hildenbrand <david@xxxxxxxxxx> wrote:
>
> On 14.09.23 17:26, Suren Baghdasaryan wrote:
> > From: Andrea Arcangeli <aarcange@xxxxxxxxxx>
> >
> > This implements the uABI of UFFDIO_REMAP.
> >
> > Notably one mode bitflag is also forwarded (and in turn known) by the
> > lowlevel remap_pages method.
>
> Sorry to say, but these functions are unacceptably long. Please find
> ways to structure the code in a better way.
Thanks for the comments, guys! I'll address them and will try to break
the functions into smaller pieces.
>
> --
> Cheers,
>
> David / dhildenb
>