Re: [PATCH v2 4/8] dt-bindings: arm-smmu: Add compatible for SM4450 SoC

[Tengfei Fan]

在 9/15/2023 3:11 PM, Krzysztof Kozlowski 写道:
> On 15/09/2023 04:15, Tengfei Fan wrote:
> > Add the SoC specific compatible for SM4450 implementing arm,mmu-500.
> >
> > Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> > index cf29ab10501c..b57751c8ad90 100644
> > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> > @@ -47,6 +47,7 @@ properties:
> >                 - qcom,sdx55-smmu-500
> >                 - qcom,sdx65-smmu-500
> >                 - qcom,sdx75-smmu-500
> > +              - qcom,sm4450-smmu-500
> >                 - qcom,sm6115-smmu-500
> >                 - qcom,sm6125-smmu-500
> >                 - qcom,sm6350-smmu-500
> > @@ -70,6 +71,7 @@ properties:
> >                 - qcom,sc8180x-smmu-500
> >                 - qcom,sc8280xp-smmu-500
> >                 - qcom,sdm845-smmu-500
> > +              - qcom,sm4450-smmu-500
>
> Isn't there comment just few lines above your edit? Comment saying DON'T?
yes, I saw this "DON'T" comment, but if I remove "qcom,sm4450-smmu-500" 
from sm4450.dtsi and this arm,smmu.yaml, will get DT check warning about 
this, this warning cannot be find after add "qcom,sm4450-smmu-500" from 
sm4450.dtsi and this arm,smmu.yaml, so update this patch again.
> Best regards,
> Krzysztof

--
Thx and BRs,
Tengfei Fan