RE: [Intel-wired-lan] [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan

[Romanowski, Rafal]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Tony Nguyen
> Sent: Friday, September 8, 2023 10:11 PM
> To: poros <poros@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx
> Cc: ivecera <ivecera@xxxxxxxxxx>; Brandeburg, Jesse
> <jesse.brandeburg@xxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx; horms@xxxxxxxxxx;
> kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; davem@xxxxxxxxxxxxx
> Subject: Re: [Intel-wired-lan] [PATCH net v2 2/2] iavf: schedule a request
> immediately after add/delete vlan
> 
> 
> 
> On 9/7/2023 8:02 AM, Petr Oros wrote:
> > When the iavf driver wants to reconfigure the VLAN filters
> > (iavf_add_vlan, iavf_del_vlan), it sets a flag in
> > aq_required:
> >    adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
> > or:
> >    adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
> >
> > This is later processed by the watchdog_task, but it runs periodically
> > every 2 seconds, so it can be a long time before it processes the request.
> >
> > In the worst case, the interface is unable to receive traffic for more
> > than 2 seconds for no objective reason.
> >
> 
> Changes look ok, however, can you supply or add a Fixes:?
> 
> > Signed-off-by: Petr Oros <poros@xxxxxxxxxx>
> > Co-developed-by: Michal Schmidt <mschmidt@xxxxxxxxxx>
> > Signed-off-by: Michal Schmidt <mschmidt@xxxxxxxxxx>
> > Co-developed-by: Ivan Vecera <ivecera@xxxxxxxxxx>
> > Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>
> > Reviewed-by: Ahmed Zaki <ahmed.zaki@xxxxxxxxx>
> > ---
> >   drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> > b/drivers/net/ethernet/intel/iavf/iavf_main.c
> > index 86d472dfdbc10c..d9f8ac1d57fd62 100644
> > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> > @@ -821,7 +821,7 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter


Tested-by: Rafal Romanowski <rafal.romanowski@xxxxxxxxx>