Re: [PATCH v2 08/15] x86/boot: Drop references to startup_64
From: Ingo Molnar
Date: Fri Sep 15 2023 - 05:16:06 EST
* Ard Biesheuvel <ardb@xxxxxxxxxx> wrote:
> From: Ard Biesheuvel <ardb@xxxxxxxxxx>
>
> The x86 boot image generation tool assign a default value to startup_64
> and subsequently parses the actual value from zoffset.h but it never
> actually uses the value anywhere. So remove this code.
>
> This change has no impact on the resulting bzImage binary.
>
> Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> ---
> arch/x86/boot/Makefile | 2 +-
> arch/x86/boot/tools/build.c | 3 ---
> 2 files changed, 1 insertion(+), 4 deletions(-)
Note that this patch conflicted with a recent upstream cleanup commit:
e78d334a5470 ("x86/boot: Mark global variables as static")
It was trivial to resolve, but please double-check the result once I push
out the new tip:x86/boot tree.
Thanks,
Ingo