Re: [PATCH V11 05/23] mmc: core: Add definitions for SD UHS-II cards

From: Victor Shih
Date: Fri Sep 15 2023 - 05:41:30 EST


On Thu, Sep 14, 2023 at 11:07 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>
> On Fri, 8 Sept 2023 at 11:53, Victor Shih <victorshihgli@xxxxxxxxx> wrote:
> >
> > From: Victor Shih <victor.shih@xxxxxxxxxxxxxxxxxxx>
> >
> > Add UHS-II specific data structures for commands and defines for
> > registers, as described in Part 1 UHS-II Addendum Version 1.01.
> >
> > UHS-II related definitions are listed below:
> > 1. UHS-II card capability: sd_uhs2_caps{}
> > 2. UHS-II configuration: sd_uhs2_config{}
> > 3. UHS-II register I/O address and register field definitions: sd_uhs2.h
> >
> > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> > Signed-off-by: Jason Lai <jason.lai@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Victor Shih <victor.shih@xxxxxxxxxxxxxxxxxxx>
> > ---
> >
>
> [...]
>
> >
> > enum sd_uhs2_operation {
> > @@ -358,6 +381,7 @@ struct mmc_host {
> > u32 max_current_330;
> > u32 max_current_300;
> > u32 max_current_180;
> > + u32 max_current_180_vdd2; /* UHS2 vdd2 max curt. */
>
> Looks unused in the series, please drop it.
>
> [...]
>
> Kind regards
> Uffe

Hi, Ulf

I will update this in the V12 version.

Thanks, Victor Shih